[PATCH] linux ttyname and ttyname_r: return link if appropriate

[Serge E. Hallyn]

On Tue, Oct 04, 2016 at 11:53:50AM +0200, Florian Weimer wrote:
> On 10/03/2016 08:16 AM, Serge E. Hallyn wrote:
> 
> >+/* Return true if this is a UNIX98 pty device, as defined in
> >+   linux/Documentation/devices.txt.  */
> >+static int
> >+is_pty (struct stat64 *sb)
> >+{
> >+#ifdef _STATBUF_ST_RDEV
> >+  int m = major (sb->st_rdev);
> >+  return (136 <= m && m <= 143);
> >+#else
> >+  return false;
> >+#endif
> >+}
> >+
> 
> Ideally, this function should go into a separate header file which
> is included.  A static inline function would be fine for this.

Yeah that would be nicer.

> >+      /* If the link doesn't exist, then it points to a device in another
> >+	 namespace.  If it is a UNIX98 pty, then return the /proc/self
> >+	 fd, as it points to a name unreachable in our namespace.  */
> 
> This comment does not appear to be correct (the /proc/self part).

D'oh, yeah that's no longer true.