[PATCH] hppa: Optimize atomic_compare_and_exchange_val_acq

[John David Anglin]

On 2016-09-28, at 5:00 PM, Florian Weimer wrote:

> * John David Anglin:
> 
>> On 2016-09-27, at 1:17 PM, Carlos O'Donell wrote:
>> 
>>> Is the FAIL->PASS for tst-stack4 reliably tied to the addition of
>>> this patch?
>> 
>> I don't think so.  It has something to do with testsuite.  When I run
>> test directly, it fails:
>> 
>> dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
>> tst-stack4: tst-stack4.c:69: dso_process: Assertion `handle[dso]' failed.
>> Didn't expect signal from child: got `Aborted'
> 
> I think you need to put the current directory on the library path.
> The test harness does this automatically to locate libpthread.so.0,
> but if you run the test manually, you need to do this yourself.


Yes, this fixes the above problem.

The test fails randomly with debian glibc_2.24-3:

dave@mx3210:~/gnu/glibc/objdir/nptl$ export LD_LIBRARY_PATH=`pwd`
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
dave@mx3210:~/gnu/glibc/objdir/nptl$ echo $?
0
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
dave@mx3210:~/gnu/glibc/objdir/nptl$ echo $?
0
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
dave@mx3210:~/gnu/glibc/objdir/nptl$ echo $?
0
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!
dave@mx3210:~/gnu/glibc/objdir/nptl$ echo $?
127
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!
dave@mx3210:~/gnu/glibc/objdir/nptl$ ./tst-stack4
dave@mx3210:~/gnu/glibc/objdir/nptl$ echo $?
0

Dave
--
John David Anglin	dave.anglin@bell.net