[PATCH] Test case for BZ 19329

Florian Weimer fweimer@redhat.com
Thu Nov 24 11:40:00 GMT 2016


On 11/24/2016 12:18 PM, Szabolcs Nagy wrote:
> Test concurrent dlopen and pthread_create when the loaded
> modules have TLS.  This triggers dl-tls assertion failures
> more reliably than the tst-stack4 test.
>
> The dlopened module has 100 DT_NEEDED dependencies and
> for me about 4000 concurrent thread creations are needed
> to see failures on x86_64.
>
> 2016-11-24  Szabolcs Nagy  <szabolcs.nagy@arm.com>
>
> 	[BZ #19329]
> 	* nptl/Makefile (tests): Add tst-tls7.
> 	(modules-names): Add tst-tls7mod, tst-tls7mod-dep.
> 	* nptl/tst-tls7.c: New file.
> 	* nptl/tst-tls7mod-dep.c: New file.
> 	* nptl/tst-tls7mod.c: New file.
>

Please do not use assert in tests.  Use the xpthread_* functions in 
test-skeleton.c instead.

This test will fail on large SMP machines due to timeouts because thread 
creation is rather expensive there.  A less resource-intense way of 
writing this test would be to iterate multiple times and try to hit the 
race each time, with a smaller number of threads created in parallel.

Florian



More information about the Libc-alpha mailing list