Add script to build many glibc configurations
Mike Frysinger
vapier@gentoo.org
Mon Nov 14 15:06:00 GMT 2016
On 11 Nov 2016 15:20, Joseph Myers wrote:
> +import os.path
this import is unnecessary
> +class Context:
please no old style classes. all of them should inherit object.
class Context(object):
> +
> + """The global state associated with builds in a given directory."""
don't put a blank line between the class and its docstring.
> + os.chmod(self.wrapper,
> + (stat.S_IRWXU|stat.S_IRGRP|stat.S_IXGRP|
> + stat.S_IROTH|stat.S_IXOTH))
the stat constants are unreadable imo. better to never use them and
stick to sane octals like 0644 and such.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20161114/18c3b5be/attachment.sig>
More information about the Libc-alpha
mailing list