[PATCH 2/6] New internal function __access_noerrno

Adhemerval Zanella adhemerval.zanella@linaro.org
Thu Nov 10 12:15:00 GMT 2016



On 10/11/2016 03:44, Siddhesh Poyarekar wrote:
> On Wednesday 09 November 2016 12:30 AM, Siddhesh Poyarekar wrote:
>> I can hack at sysdeps/unix/sysv/linux/access.c and drop
>> sysdeps/unix/access_noerrno.c.
> 
> Turns out I can't do this because I will be breaking non-Linux
> configurations that use the SYS_ prefix instead of the __NR_ prefix.  I
> also discovered that I hadn't actually tested the code properly on
> aarch64 and it is broken, so I'll resend the patchset.
> 
> Siddhesh

In this branch [1] I have a WIP for this.  First patch basically
consolidates access Linux implementation and it uses the strategy
to check for __NR_access first (and since it on sysdeps/.../linux
it should not worry about __SYS_*).

Second one is the __access_errno implementation.  It basically handles
the 3 cases (hurd, nacl, and Linux) by adding the __access_errno on
access.c.

I think it should a cleaner solution to __access_noerro (less macro
handling and build objects).


[1] https://github.com/zatrazz/glibc/commits/master-access_noerrno



More information about the Libc-alpha mailing list