[PATCH] Speed up math/test-tgmath2.c
Steve Ellcey
sellcey@caviumnetworks.com
Fri Nov 4 18:06:00 GMT 2016
On Fri, 2016-11-04 at 17:25 +0000, Joseph Myers wrote:
> On Fri, 4 Nov 2016, Steve Ellcey wrote:
>
> >
> > >
> > > +Â Â return test_cos (vint1, vllong1)
> > > + Â + test_fabs (vint1, vllong1)
> > > + Â + test_conj (vint1, vllong1)
> > > + Â + test_expm1 (vint1, vllong1)
> > > + Â + test_lrint (vint1, vllong1)
> > > + Â + test_ldexp (vint1, vllong1)
> > > + Â + test_atan2 (vint1, vllong1)
> > > + Â + test_remquo (vint1, vllong1)
> > > + Â + test_pow (vint1, vllong1)
> > > + Â + test_fma_1 (vint1, vllong1)
> > > + Â + test_fma_2 (vint1, vllong1)
> > > + Â + test_fma_3 (vint1, vllong1)
> > > + Â + test_fma_4 (vint1, vllong1);
> You don't want to add up test results like that; you should OR themÂ
> together instead, to avoid the potential for test results adding up
> to 77 and wrongly becoming UNSUPPORTED.  (In this case of course
> there aren't enough tests to get to 77, but the principle applies
> that you should avoid the test return being a count of something.)
I'll fix that and resubmit. Â Is there documentation on what do_test
should return? Â I looked at test-skeleton.c but there was nothing in
there about what do_test/TEST_FUNCTION should return for different
results (PASS/FAIL/UNSUPPORTED). Â I didn't see anything in the Wiki
about return values from do_test either.
Steve Ellcey
sellcey@caviumnetworks.com
More information about the Libc-alpha
mailing list