[PATCH] Fix -Wformat-length warning in time/tst-strptime2.c

Carlos O'Donell carlos@redhat.com
Wed Nov 2 20:55:00 GMT 2016


On 11/02/2016 03:47 PM, Steve Ellcey wrote:
> Here is an updated version of my earlier patch, I hadn't tested the
> original one with an old GCC so I hadn't realized I needed to put the
> DIAG_IGNORE_NEEDS_COMMENT in an ifdef.  This version was tested with
> GCC 5.4 and GCC 7.0 with no regressions.
> 
> I also double checked that the test program is deliberately using
> snprintf to truncate the output so changing the test by increasing the
> buffer size and avoiding the warnings that way would change what was
> being tested.
> 
> OK to checkin?

LGTM.

c.



More information about the Libc-alpha mailing list