[PATCH v2] When using the Mozilla NSS library for cryptography, include the NSPR header files

[Guido Trentalancia]

Hello again.

On Tue, 31/05/2016 at 15.50 -0300, Adhemerval Zanella wrote:
> 
> On 31/05/2016 14:28, Guido Trentalancia wrote:
> > Hello Adhemerval.
> > 
> > I'll try to get back on the problem that you mention...
> > 
> > On Tue, 31/05/2016 at 11.39 -0300, Adhemerval Zanella wrote:
> > > 
> > > On 31/05/2016 09:35, Guido Trentalancia wrote:
> > > > When configuring and building GNU libc using the Mozilla NSS
> > > > library
> > > > for cryptography (--enable-nss-crypt option), also include the
> > > > NSPR header files along with the Mozilla NSS library header
> > > > files.
> > > > 
> > > > Signed-off-by: Guido Trentalancia <guido@trentalancia.net>
> > > 
> > > This patch is missing a proper ChangeLog [1]

By the way, I have re-submitted the patch with the ChangeLog. So, it's
just waiting to be committed...

> > > [1]
> > > https://sourceware.org/glibc/wiki/Contribution%20checklist#Proper
> > > ly_Formatted_GNU_ChangeLog
> > > 
> > > > ---
> > > >  configure      |    6 +++++-
> > > >  configure.ac   |    6 +++++-
> > > > Â crypt/Makefile |Â Â Â Â 6 +++---
> > > > Â 3 files changed, 13 insertions(+), 5 deletions(-)
> > > > 
> > > > --- glibc-31052016-0900GMT/configure	2016-05-30
> > > > 13:25:35.299696688 +0200
> > > > +++ glibc-configure-nss-crypt-include-nspr-headers/configure	
> > > > 2016-05-31 13:57:28.117571376 +0200
> > > > @@ -3501,8 +3501,12 @@ if test x$nss_crypt = xyes; then
> > > > Â Â Â if test $? -ne 0; then
> > > > Â Â Â Â Â as_fn_error $? "cannot find include directory with nss-
> > > > config"Â 
> > > > "$LINENO" 5
> > > > Â Â Â fi
> > > > +Â Â nspr_includes=-I$(nspr-config --includedir 2>/dev/null)
> > > > +Â Â if test $? -ne 0; then
> > > > +Â Â Â Â as_fn_error $? "cannot find include directory with nspr-
> > > > config" "$LINENO" 5
> > > > +Â Â fi
> > > > Â Â Â old_CFLAGS="$CFLAGS"
> > > > -Â Â CFLAGS="$CFLAGS $nss_includes"
> > > > +Â Â CFLAGS="$CFLAGS $nss_includes $nspr_includes"
> > > 
> > > I tried to build it on Ubuntu 16.04 and even with the patch
> > > configure
> > > failed
> > > due it could not find libfreebl3.so.  On this distro this is
> > > installed on
> > > /usr/lib/x86_64-linux-gnu/nss/ and I am not familiar with this
> > > project to say
> > > if this is the default folder, if it is something recently
> > > changed or
> > > if it a
> > > distro-based modification.  

[...]

> > Try adding "/usr/lib/x86_64-linux-gnu/nss/" to LDFLAGS and passing
> > such
> > variable to configure, for example as follows (please adapt it to
> > your
> > needs):
> > 
> > LDFLAGS="-L/usr/lib/x86_64-linux-gnu/nss" configure --enable-nss-
> > crypt
> > --whatever-other-options-you-might-need
> 
> It is indeed an ubuntu/debian modification (patch
> 85_security_load.patch 
> from libnss3 package) and I think it mainly due ubuntu/debian does
> not
> build glibc with NSS flag.

So, have you managed to configure GNU libc to use the Mozilla NSS
library on your distribution ? Set LDFLAGS as mentioned above,
eventually export it and run configure. The configure script should
then be able to link the test program correctly...

I look forward to hearing from you.

Best regards,

Guido Trentalancia