[PATCH 3/3] posix: New Linux posix_spawn{p} implementation

Adhemerval Zanella adhemerval.zanella@linaro.org
Mon May 30 13:07:00 GMT 2016



On 30/05/2016 08:02, Florian Weimer wrote:
> On 05/29/2016 11:54 AM, Eric Wong wrote:
>> Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>>> +static int
>>> +__spawni_child (void *arguments)
>>
>> <snip>
>>
>>> +fail:
>>> +  /* Since sizeof errno < PIPE_BUF, the write is atomic. */
>>> +  ret = -ret;
>>> +  if (ret)
>>> +    while (write_not_cancel (p, &ret, sizeof ret) < 0)
>>> +      continue;
>>> +  exit (SPAWN_ERROR);
>>> +}
>>
>> Sorry for not noticing earlier, but shouldn't it be
>> "_exit" instead of "exit" when the child fails?
> 
> Good point.  Would you file a bug for this, please?
> 
> Thanks,
> Florian

Thanks for reporting, I opened BZ#20178.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=20178



More information about the Libc-alpha mailing list