[PATCHv3 08/11] Apply LIT(x) to floating point literals in libm-test.c

Joseph Myers joseph@codesourcery.com
Fri May 27 17:32:00 GMT 2016


On Thu, 26 May 2016, Paul E. Murphy wrote:

> +# Apply a prefix and suffix to a floating point value after
> +# stripping the suffix, or return the unaltered string.
> +sub wrap_lit {
> +  my ($lit,$prefix,$suffix) = @_;

Use spaces after commas.

> +  # base 10 integer raised to a power,

I think you mean base 10 integer with an exponent / times 10 to a 
power....

> +      } elsif ($descr[$i] eq "j") {
> +        $cline .= ", " . &apply_suf ($args[$current_arg], "L");

I don't see a use in replacing suffixes for the long double argument to 
nexttoward.  I'd just expect the source file to have the right suffix if 
needed and leave it unchanged, as for integer arguments.  (This then means 
apply_suf is unneeded.)

> +	} elsif ($_ eq "j") {
> +          $result = apply_suf ($result, "L");

Likewise.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list