[PATCHv3 1/3] Refactor tst-strtod-round.c
Paul E. Murphy
murphyp@linux.vnet.ibm.com
Tue May 24 20:03:00 GMT 2016
On 05/24/2016 10:12 AM, Joseph Myers wrote:
> On Mon, 23 May 2016, Paul E. Murphy wrote:
>
>> + char *fin_name = argv[1];
>> + char *fout_name = argv[2];
>> +
>> + if (argc < 3)
>> + {
>> + fprintf (stderr, "Usage: %s [input] [output]\n", basename (argv[0]));
>> + return EXIT_FAILURE;
>> + }
>
> The check for argc < 3 should take place before you access argv[1] and
> argv[2] (if no arguments are passed, argv[2] doesn't exist). And you
> shouldn't have [] around "input" and "output" in the message since that
> suggests they are optional, which they aren't (cf. gen-auto-libm-tests
> using <>).
>
> OK with those changes.
>
Requested changes made. Pushed as 118fbf0.
More information about the Libc-alpha
mailing list