[PATCHv2 11/14] Apply LIT(x) to floating point literals in libm-test.c
Joseph Myers
joseph@codesourcery.com
Tue May 24 16:26:00 GMT 2016
On Fri, 20 May 2016, Paul E. Murphy wrote:
> if ($descr[$i] =~ /f|i|l|L/) {
> - $cline .= ", $args[$current_arg]";
> + if ($descr[$i] eq "f" and not ($args[0] eq "nexttoward" and $current_arg == 2)) {
Rather than specially checking for the name "nexttoward" here, I think it
would be cleaner to use something other than "f" as the argument
descriptor for the case where the argument is always long double, and
rename struct test_ff_f_data_nexttoward accordingly. (Strictly you don't
need to create another macro like RUN_TEST_LOOP_ff_f with the
corresponding name and use it for the nexttoward tests, but it's probably
cleaner to do so as well.)
(Nothing should actually be using the first argument to TEST_* any more;
it's a relic from when TEST_* generated code rather than data, which
hasn't been cleaned up yet.)
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list