[PATCH] libio: use PTR_MANGLE/PTR_DEMANGLE for FILE vtables

[Mike Frysinger]

On 23 May 2016 13:02, Kees Cook wrote:
> --- a/libio/libioP.h
> +++ b/libio/libioP.h
> +static inline void
> +__mangle_vtable(const struct _IO_jump_t **vtable, const struct _IO_jump_t *table)

any reason to not use a name like "_IO_mangle_vtable" ?

GNU style says to put a space before the (

> +{
> +    struct _IO_jump_t *ptr = (struct _IO_jump_t *)table;
> +#ifndef USE_COMPAT_LIBIO
> +    PTR_MANGLE (ptr);
> +#endif
> +    *vtable = ptr;
> +}

GNU style says indent with 2 spaces rather than 4

otherwise, lgtm
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160523/7e6192b1/attachment.sig>