[PATCHv2 1/6] Refactor bug-strtod.c to better test new types.

Paul E. Murphy murphyp@linux.vnet.ibm.com
Mon May 23 19:41:00 GMT 2016



On 05/20/2016 02:59 PM, Joseph Myers wrote:
> On Tue, 17 May 2016, Paul E. Murphy wrote:
> 
>> +#define TEST_STRTOD(FSUF, FTYPE, FTOSTR, FTOSTRM, LSUF, CSUF)		\
>> +static int test_strto ## FSUF (void)					\
> 
> Also, please fix formatting here so the function name starts a new line 
> after the return type.

...

>> +	  FTOSTR (fstr, sizeof(fstr), "%" FTOSTRM "g", f);		\
>> +	  FTOSTR (fcntstr, sizeof(fstr), "%" FTOSTRM "g", (FTYPE) cnt);	\
>
> Missing spaces before '(' in sizeof calls.  The patch is OK with that 
> fixed.

Fixed.

And, a slightly corrected changelog entry based on comments from
the glut of my other outstanding changes:

        * stdlib/bug-strtod.c (main):
        refactor into ...
        (TEST_STRTOD): New macro function.
        * stdlib/tst-strtod.h: New file.

Ok for commit?  If so, I'll push the first 3 patches in this series
to reduce the churn as I work through the remaining 3 patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refactor-bug-strtod.c-to-better-test-new-types.patch
Type: text/x-patch
Size: 5533 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160523/c8dc5cad/attachment.bin>


More information about the Libc-alpha mailing list