[PATCH] Make padding in struct sockaddr_storage explicit [BZ #20111]

Andreas Schwab schwab@suse.de
Thu May 19 15:28:00 GMT 2016


Florian Weimer <fweimer@redhat.com> writes:

> What if we put the padding in the middle, like this?
>
> #define _SS_PADSIZE \
>   _SS_SIZE - __SOCKADDR_COMMON_SIZE - sizeof (__ss_aligntype)

That is different from the current definition, potentially increasing
the size of the structure.  The problem with the current definition is
that it assumes that offsetof (struct sockaddr_storage, __ss_align) ==
sizeof (__ss_aligntype), which is not guaranteed.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list