[PATCH 4/5] Refactor tst-strtod-round.c

[Paul E. Murphy]

On 05/16/2016 05:49 PM, Joseph Myers wrote:
> On Mon, 16 May 2016, Paul E. Murphy wrote:
> 
>> +   gcc -std=gnu11 -O2 -Wall -Wextra gen-tst-strtod-round.c -lmpfr
>> +     -o gen-tst-strtod-round
>> +
>> +   (use of current MPC and MPFR versions recommended) and run it as:
> 
> The reference to MPC can't be correct.  This program does not use MPC.

Indeed, unnecessary.  I forgot to remove that bit after grabbing it
from gen-auto-tst-libm-tests.c.

> 
> So far this message has reached the libc-alpha list twice (you don't see 
> it twice in the archives because it has the same message-id each time).  
> I've seen this issue before with large messages coming to libc-alpha from 
> IBM (many duplicate copies of them arrive on the list), as if there is 
> some problem with IBM's mail server timing out before sourceware accepts 
> the message, or something like that.  Please try to get that mail system 
> problem fixed.

Ugh.  Thanks for pointing that out.  That is annoying.  I'll try.
 
> A further refactoring will be needed for testing new types with existing 
> formats: constant suffixes will need to be added when the header is used, 
> rather than being included when it is generated, so that the generated 
> constants for binary128 can be used with either "L" or "f128" (well, "q" 
> absent GCC support for "f128") suffixes depending on the type 
> corresponding to that format.  Do you intend to do that in a separate 
> patch?

Yes, I intentionally have avoided float128 specific changes.  I was
planning on just adding another entry to the formats table of
gen-tst-strtod-round.c and regenerating.  But, on second thought, with
a few small changes to the generator, it is possible to make the
generated output fully type generic.  I've attached the change which
applies atop patch 5.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refactor-tst-strtod-round-data.h-to-avoid-adding-a-t.patch
Type: text/x-patch
Size: 5309 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160517/40194ce3/attachment.bin>