[PATCH v2 2/2] powerpc: Fix operand prefixes

Tulio Magno Quites Machado Filho tuliom@linux.vnet.ibm.com
Tue May 3 14:25:00 GMT 2016


"Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com> writes:

> The file sysdeps/powerpc/sysdeps.h defines aliases for condition register
> operands.  E.g.: 'cr7' means condition register 7.  On the one hand, this
> increases readability, as it makes it easier for readers to know whether the
> operand is a condition register, a general purpose register or an immediate.
> On the other hand, this permits that condition registers be written as if they
> were general purpose, and vice-versa, thus reducing the readability of the
> code.
>
> This commit removes some of these unintentional misuses.
>
> The changes have no effect on the final code.  Checked with objdump.
>
> 2016-04-18  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>
>
> 	* sysdeps/powerpc/powerpc64/power8/strncpy.S: Fix use of condition
> 	registers specifiers where general purpose registers specifiers should
> 	have been used.

LGTM.

-- 
Tulio Magno



More information about the Libc-alpha mailing list