[COMMITTED] [PATCH] posix: Fix posix_spawn invalid memory access

Andreas Schwab schwab@suse.de
Mon Mar 21 14:10:00 GMT 2016


Florian Weimer <fw@deneb.enyo.de> writes:

> * Adhemerval Zanella:
>
>> -  if (!ec && new_pid)
>> +  if (!ec && pid)
>
> I think the general convention is not to perform implicit NULL checks,
> so it should be “pid != NULL”.

For the same reason "!ec" should be changed to "ec == 0".

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list