[PATCH] glob: Avoid copying the d_name field of struct dirent [BZ #19779]

Paul Eggert eggert@cs.ucla.edu
Fri Mar 11 22:00:00 GMT 2016


I merely read the patch. Comments:

 > +static void
 > +convert_dirent (const struct dirent *source, struct abstract_dirent *target)

Since this is all inlined, how about if making it a pure function, with a 
signature like this instead?

static struct abstract_dirent
convert_dirent (struct dirent const *source)

That should be a bit cleaner.

Otherwise, it looks good.



More information about the Libc-alpha mailing list