[PING 2][PATCH v3] Add pretty printers for the NPTL lock types

Martin Galvan martin.galvan@tallertechnologies.com
Fri Mar 11 14:31:00 GMT 2016


On Fri, Mar 11, 2016 at 1:30 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> This is really awesome.
>
> From a high level I think the testing is coming along very nicely.

Thanks a lot! I'm glad to hear that.

> One things I'd like to see:
>
> * Test timeouts? What if the tests get stuck?
>   - I don't see how you control the timeouts or time them to
>     the existing TIMEOUTFACTOR or define default timeouts.

pexpect.spawn takes a 'timeout' parameter, which tells it how long it
should wait for the target to output a matching response after each
call to expect(). If the expect() call times out, an exception is
raised and the test exits with code 1.

I arbitrarily set that timeout to 1 second, but I can change that. Is
TIMEOUTFACTOR an environment variable you can set when running make
check?



More information about the Libc-alpha mailing list