[PATCH] getnameinfo: Do not restore errno on error

Andreas Schwab schwab@suse.de
Tue Mar 8 15:27:00 GMT 2016


Zack Weinberg <zackw@panix.com> writes:

> This might be OK in the actual error case, but you're stomping on
> errno in the *non*-error case too, which, even if allowed, should be
> avoided as a matter of QoI.

There are only very few functions (as required by POSIX) that preserve
errno on success.  Why does getnameinfo need to be in this list?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list