[PATCH] getnameinfo: Do not restore errno on error

Florian Weimer fweimer@redhat.com
Tue Mar 8 15:20:00 GMT 2016


On 03/08/2016 04:14 PM, Zack Weinberg wrote:
> On Tue, Mar 8, 2016 at 9:27 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> POSIX does not require it, and this behavior is not documented
>> in the manual page, either.
> 
> This might be OK in the actual error case, but you're stomping on
> errno in the *non*-error case too, which, even if allowed, should be
> avoided as a matter of QoI.

We currently do not have this as a general goal for glibc functions.  I
don't think getnameinfois special so that an exception is warranted (
(unlike, say, free).

Florian



More information about the Libc-alpha mailing list