[PATCH v2] Remove union wait (was: Re: Deprecate union wait and remove support from wait functions [BZ #19613])

Florian Weimer fweimer@redhat.com
Tue Mar 8 09:57:00 GMT 2016


On 03/07/2016 11:55 PM, Roland McGrath wrote:
> I don't see a rationale for keeping union wait at all if it can be longer
> be used with the wait* functions.

I think it can, you just get a pointer conversion warning, and have to
use the union members (which are the original interface) instead of the
macro wrappers.

> If we need staged deprecation, then it
> should be a staged deprecation of all the features (with the possible
> exception of W* macros accepting 'union wait' argument values, which was
> always a GNU extension over the 4.3BSD API that specified 'union wait').
> Personally I'm OK with just removing it entirely in one cycle.

Okay, let's do it this way.  New patch attached.

>> 	* sunrpc/key_call.c (key_call_keyenvoy): Use int instead of union
>> 	wait.
> 
> This one change could and should go in separately first.

Done.

Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-union-wait-BZ-19613.patch
Type: text/x-patch
Size: 16758 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160308/3d9d6c9d/attachment.bin>


More information about the Libc-alpha mailing list