[PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]

Florian Weimer fweimer@redhat.com
Mon Mar 7 15:58:00 GMT 2016


On 03/07/2016 04:28 PM, Carlos O'Donell wrote:

> I tend to agree with Martin here, having that separation between
> test and data makes it easier to read and change the test or add
> more tests.
> 
> If you're getting a warning from the compiler you expect but don't
> care about then you can just silence the warning with the appropriate
> attribute?

The warning is not enabled by default (or even -W), so I'm not sure if
that's even necessary.

What's your opinion on the separate static test?  Should I include it?

Thanks,
Florian



More information about the Libc-alpha mailing list