[PATCH] Copy x86_64 _mcount.op from _mcount.o

Roland McGrath roland@hack.frob.com
Fri Mar 4 00:10:00 GMT 2016


I don't understand why you thought this was a change that should go in
immediately without review.

No change that introduces a new variable to the protocol between generic
makefiles and sysdeps/.../Makefile fragments should go in without review.

This is not at all in the "obvious enough" category, so I really don't
see any justification for committing it without waiting a normal amount
of time for normal review.

The burden is always on you to justify why normal review can be skipped.
I should not need to give you reasons why it should not have been skipped.

If I'd had a chance to review this change, I'd have said that I don't see
any adequate rationale for this change.  You said it was a no-op change, so
clearly it was not actually needed for anything.  I don't think the trivial
amount of build time added by assembling one small file is anywhere near
adequate to justify the maintenance burden of a fiddly makefile change like
this.



More information about the Libc-alpha mailing list