[PATCH 3/6] Convert _Complex cosine functions to generated code

Joseph Myers joseph@codesourcery.com
Thu Jun 30 22:36:00 GMT 2016


On Thu, 30 Jun 2016, Paul E. Murphy wrote:

> +      if (__real__ res == M_LIT (0.0))

As a general principle for all such changes:

Macroization makes the code less readable, so should be avoided where not 
necessary.  In particular, where implicit conversions from integers to 
floating point will suffice to give the right floating-point value with 
the right type, use integers, so use integer 0 here, and make similar 
changes throughout this patch series whenever the floating-point constant 
has a small value (not -0) representable in int.  (Of course, explicit 
-0.0 does need to use a floating-point constant, not an integer constant.)

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list