[RFC PATCH] AARCH64/ILP32: introduce kernel time types

Florian Weimer fweimer@redhat.com
Tue Jun 28 08:51:00 GMT 2016


On 06/28/2016 10:44 AM, Yury Norov wrote:
> Structures utmp and utmpx are shared between ilp32 and native ABIs,
> and so should have same layout. As now, architectures where this
> compatibility is required enable __WORDSIZE_TIME64_COMPAT32 option,
> and so make lp64 utmp{x} backward-compatible to ilp32 ones.
>
> AARCH64 doesn't require such compatibility, and so we can do opposite
> conversion.

Thanks, I agree this is the right way forward.

> This patch introduces new option  __KERNEL_TIME_T_MATCHES_TIME64_T,

> +struct __kernel_timeval
> +  {
> +    __ktime_t tv_sec;		/* Seconds.  */
> +    __ksuseconds_t tv_usec;	/* Microseconds.  */
> +  };

We rarely use the __KERNEL_ and __kernel_ prefixes, but the kernel uapi 
includes do.  I would suggest to use a different prefix.

Thanks,
Florian



More information about the Libc-alpha mailing list