[PATCH] powerpc: Add a POWER8-optimized version of expf()
Tulio Magno Quites Machado Filho
tuliom@linux.vnet.ibm.com
Mon Jun 27 13:33:00 GMT 2016
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> On 06/23/2016 03:53 PM, Tulio Magno Quites Machado Filho wrote:
>> +#ifndef __ieee754_expf
>> +# define IS_MAIN_DEF
>> +#endif
>
>> +#ifdef IS_MAIN_DEF
>> +strong_alias (__ieee754_expf, __expf_finite)
>> +#endif
>>
>
> This is inconsistent with many of the other ppc64
> multiarch files.
>
> Why not undef and redefine strong_alias in
> e_expf-power8.S?
It's intentional.
Because undef doesn't make it clear when the macro is defined or not.
So, you reach a code that may do nothing depending on how this file
was included.
> Similarly, the formatting seems inconsistent with
> the other PPC asm.
Could you give me more details, please?
--
Tulio Magno
More information about the Libc-alpha
mailing list