[PATCH 12/14] Drop explicit stack-protection of pieces of the system.

Florian Weimer fweimer@redhat.com
Fri Jun 24 13:25:00 GMT 2016


On 06/07/2016 01:06 PM, Nix wrote:
> From: Nick Alcock <nick.alcock@oracle.com>
>
> This is probably a bad idea: maybe we want to stack-protect some parts
> of the system even when ! --enable-stack-protector.  I can easily adjust
> the patch to do that (though it'll mean introducing a new variable
> analogous to $(stack-protector) but not controlled by the configure
> flag.)
>
> But if we wanted to value consistency over security, and use the same
> stack-protection configure flag to control everything, this is how we'd
> do it!
>
> ("Always include at least one patch with something obviously wrong with
> it.")
>
> 	* login/Makefile (pt_chown-cflags): Remove.
> 	* nscd/Makefile (CFLAGS-nscd): Likewise.
> 	* resolv/Makefile (CFLAGS-libresolv): Likewise.

I would like to see this go in.  The existing logic is very misleading, 
particularly in resolv/Makefile, where nss_dns is *not* protected.

Thanks,
Florian



More information about the Libc-alpha mailing list