[PATCH] Return proper status from _nss_nis_initgroups_dyn (bug 20262)

Florian Weimer fweimer@redhat.com
Thu Jun 23 16:51:00 GMT 2016


On 06/16/2016 04:06 PM, Andreas Schwab wrote:
> 	[BZ #20262]
> 	* nis/nss_nis/nis-initgroups.c (_nss_nis_initgroups_dyn): Return
> 	NSS_STATUS_SUCCESS when done.  Return NSS_STATUS_TRYAGAIN when out
> 	of memory.

Thanks for the patch.

What about this loop exit?

		    if (limit > 0 && *size == limit)
		      /* We reached the maximum.  */
		      goto done;

Shouldn't the caller somehow learn about truncation?

Is the internal initgroups_dyn interface used by anything else but nscd?

Florian



More information about the Libc-alpha mailing list