[PATCH] test-skeleton: redirect stderr to stdout

[Andreas Schwab]

Zack Weinberg <zackw@panix.com> writes:

> On Thu, Jun 16, 2016 at 12:48 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> +  fclose (stderr);
>> +  dup2 (STDOUT_FILENO, STDERR_FILENO);
>> +  stderr = fdopen (STDERR_FILENO, "w");
>
> Wouldn't the dup2 be sufficient by itself?  And then you don't have to
> worry about allocation failure in fdopen.
>
> Also a setbuf(stderr, NULL) is probably appropriate.

Also, assigning stderr is a nono.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."