[RFC v2][PATCH 22/27] Export stack_used as __stack_used

Gary Benson gbenson@redhat.com
Mon Jun 13 11:24:00 GMT 2016


Gary Benson wrote:
> Pedro Alves wrote:
> > BTW, the td_ta_thr_iter.c::iterate_thread_list hunk looks like
> > just a code style change unrelated to the subject of the patch.
> 
> It's not a style change, it stops it falling through into the rest
> of the function if next == 0 and !fake_empty.
> 
> I agree it should be a separate patch though.

Oh, wait, no, I remember: the reason it's not a separate patch is
that stack_user is statically initialized, so next == 0 never
occurred.  But, changing it to __stack_user changed how it has to
be initialized, so next == 0 can now occur.

So it should be the same patch (but maybe it needs documenting!)

Cheers,
Gary

-- 
http://gbenson.net/



More information about the Libc-alpha mailing list