[PATCH v7] Add pretty printers for the NPTL lock types

[Martin Galvan]

On Wed, Jun 8, 2016 at 11:01 AM, Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
> On Wed, Jun 08, 2016 at 10:36:37AM -0300, Martin Galvan wrote:
> > I don't think it's a good idea to change anything in the source dir
> > when building. The only time I've had to do something like that is
> > when running a bootstrap script. If anything, the pretty printers
> > would have to be added to .gitignore or something.
>
> It is quite a standard practice in glibc to generate files in the
> source directory (similar to the configure script from configure.ac)
> if the file is going to be mostly unchanged, which is true for your
> constants file.  Like the configure script, the generated file should
> be added to the patch, so you don't need to added it to .gitignore.

As you wish.

> This also means that you add a comment to the generated file saying
> that it is automatically generated and it should not be modified by
> hand.

I do, actually:

+       echo '# GENERATED FILE\n' > $@.tmp2
+       echo '# Constant definitions for pretty printers.' >> $@.tmp2
+       echo '# See gen-py-const.awk for details.\n' >> $@.tmp2