[PATCH][AArch64] Add rawmemchr

Alexander Cherepanov ch3root@openwall.com
Thu Jun 2 17:13:00 GMT 2016


On 2016-06-02 16:32, Szabolcs Nagy wrote:
> On 02/06/16 14:08, Alexander Cherepanov wrote:
>> On 2016-05-27 16:29, Wilco Dijkstra wrote:
>>> Add a simple rawmemchr implementation. Use strlen for rawmemchr(s, '\0') as
>>> it is the fastest way to search for '\0'.  Otherwise use memchr with an infinite size.
>>> This is 3x faster on benchtests for large sizes.
>>
>> Is memchr on your arch guaranteed to work with an infinite size?
>>
>> In theory, it's guaranteed by C11 and POSIX (e.g. see http://open-std.org/jtc1/sc22/wg14/www/docs/n1533.htm )
>> but IIUC there is a sentiment in the glibc community that passing to a library function a size greater than the
>> real size of an object is an error. (Would be glad to find out I misunderstood something here.)
>
> why would the glibc community want something that's in
> conflict with the standard?

Because what is in the standard is considered a mistake, because it 
hinders the possibilities to catch bugs in user code, or something like 
that. Not sure exactly.

The most controversial so far is fread. The kernel will fail the read if 
you pass to it a pointer/size that don't fit into user space (e.g. 
47-bits on x86-64) so you cannot call fread with the size anywhere close 
to SIZE_MAX.

-- 
Alexander Cherepanov



More information about the Libc-alpha mailing list