[PATCH x86-64][BZ #20024] Fixed vector sincos/sincosf ABI

[Carlos O'Donell]

On 05/31/2016 03:25 PM, Andrew Senkevich wrote:
> Hi,
> 
> this patch fixes wrong vector sincos/sincosf ABI to have it compatible with
> current vector function declaration.  According to current vector function
> declaration vectorized sincos should have vector of pointers for second and
> third parameters, so it is fixed with implementation as wrapper to version
> having second and third parameters as pointers.
> Is it Ok for trunk, 2.22 and 2.23 releases branches?

How did you test this? Is it possible to add a regression test that detects
this issue?

> 2016-05-31  Andrew Senkevich  <andrew.senkevich@intel.com>
> 
>         [BZ #20024]
>         * sysdeps/x86_64/fpu/multiarch/svml_d_sincos2_core_sse4.S: Fixed ABI
>         of this implementation of vector function.
>         * sysdeps/x86_64/fpu/multiarch/svml_d_sincos4_core_avx2.S: Likewise.
>         * sysdeps/x86_64/fpu/multiarch/svml_d_sincos8_core_avx512.S: Likewise.
>         * sysdeps/x86_64/fpu/multiarch/svml_s_sincosf16_core_avx512.S:
>         Likewise.
>         * sysdeps/x86_64/fpu/multiarch/svml_s_sincosf4_core_sse4.S: Likewise.
>         * sysdeps/x86_64/fpu/multiarch/svml_s_sincosf8_core_avx2.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_d_sincos2_core.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_d_sincos4_core.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_d_sincos4_core_avx.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_d_sincos8_core.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_s_sincosf16_core.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_s_sincosf4_core.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_s_sincosf8_core.S: Likewise.
>         * sysdeps/x86_64/fpu/svml_s_sincosf8_core_avx.S: Likewise.
>         * sysdeps/x86_64/fpu/test-double-vlen2-wrappers.c: Redefined wrapper
>         for testing vector function with fixed ABI.
>         * sysdeps/x86_64/fpu/test-double-vlen4-avx2-wrappers.c: Likewise.
>         * sysdeps/x86_64/fpu/test-double-vlen4-wrappers.c: Likewise.
>         * sysdeps/x86_64/fpu/test-double-vlen8-wrappers.c: Likewise.
>         * sysdeps/x86_64/fpu/test-float-vlen16-wrappers.c: Likewise.
>         * sysdeps/x86_64/fpu/test-float-vlen4-wrappers.c: Likewise.
>         * sysdeps/x86_64/fpu/test-float-vlen8-avx2-wrappers.c: Likewise.
>         * sysdeps/x86_64/fpu/test-float-vlen8-wrappers.c: Likewise.


>         * sysdeps/x86_64/fpu/libm-test-ulps: Regenerated on KNL.

This should be a separate patch that you commit without any real need
for discussion (unless the numbers are way out).

Cheers,
Carlos.

-- 
Cheers,
Carlos.