[PATCH] Fix htonl, htons, ntohl, ntohs functions on big endian systems

Zack Weinberg zackw@panix.com
Sun Jul 31 08:59:00 GMT 2016


On Sat, Jul 30, 2016 at 6:59 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
>
> This patch attempts to fix that. It adds an implicit cast for ntohl and
> htonl using a GCC extension or an explicit one when not using GCC. It
> adds an explicit cast for ntohs and htons as the call to __bswap_16
> contains an explicit cast.

I support fixing this.  However, what is the benefit of the "implicit
cast" construct over the "explicit"?  It seems like gratuitous
#ifdeffage at first sight.

zw



More information about the Libc-alpha mailing list