[PATCH 1/2] Add framework for tunables

H.J. Lu hjl.tools@gmail.com
Wed Jul 13 18:03:00 GMT 2016


On Wed, Jul 13, 2016 at 10:59 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Jul 13, 2016 at 10:55 AM, Siddhesh Poyarekar
> <siddhesh@sourceware.org> wrote:
>> On Wed, Jul 13, 2016 at 10:37:56AM -0700, H.J. Lu wrote:
>>> This scheme doesn't work well for IFUNC.  cpu_features must be
>>> updated very early after init_cpu_features is called.  But __tunables_init
>>> is called too late.  Can it be moved before init_cpu_features so that
>>> cpu_features can be updated at the end of init_cpu_features?
>>
>> Sure, I'll move it further up.
>
> Please make sure that it is called before init_cpu_features for both
> static and dynamic executables.
>

Another thing, please add TUNABLE_WITH_CALLBACK:

TUNABLE_WITH_CALLBACK (ifunc, ifunc);

so that I can have a callback without setting a value.

-- 
H.J.



More information about the Libc-alpha mailing list