[PATCH] string: Additional test for strcmp, strcasecmp

[Florian Weimer]

On 07/07/2016 06:25 PM, Rajalakshmi Srinivasaraghavan wrote:
>
>
> On 07/07/2016 09:46 PM, Florian Weimer wrote:
>> On 07/07/2016 06:06 PM, Rajalakshmi Srinivasaraghavan wrote:
>>>
>>>
>>> On 07/05/2016 05:49 PM, Florian Weimer wrote:
>>>> 2016-07-05  Florian Weimer <fweimer@redhat.com>
>>>>
>>>>     * string/tst-cmp.c: New test.
>>>>     * string/Makefile (tests): Add it.
>>
>>> LGTM. Just one comment.
>>
>> Thanks.
>>
>>> Can you include strncmp and strncasecmp as well?
>>
>> What shall we do about the length argument?  Keep it constant at 64 or
>> something like that?

> Either constant or strlen(left + left_align)+1.

That alters the result of the comparison.  We would have to use the 
maximum over both string lengths, I think.

Florian