[PATCH] S390: Use DT_JUMPREL in prelink undo code.

Carlos O'Donell carlos@redhat.com
Wed Jul 6 15:15:00 GMT 2016


On 07/06/2016 09:28 AM, Stefan Liebler wrote:
> On 07/05/2016 10:17 AM, Florian Weimer wrote:
>> On 06/30/2016 06:28 PM, Stefan Liebler wrote:
>>>     * sysdeps/s390/linkmap.h (struct link_map_machine):
>>>     Remove member gotplt and add member jmprel.
>>>     * sysdeps/s390/s390-32/dl-machine.h
>>>     (elf_machine_runtime_setup): Setup member jmprel with DT_JMPREL
>>>     instead of gotplt with &got[3].
>>>     (elf_machine_lazy_rel): Calculate address with reloc and jmprel.
>>>     * sysdeps/s390/s390-64/dl-machine.h: Likewise.
>>
>> I don't see anything obviously wrong with this patch (which doesn't mean
>> much, it's hardly my area of expertise).
>>
>> If you, as one of the architecture maintainers, think this is the right
>> way forward, please commit it.
>>
>> Thanks,
>> Florian
>>
> Okay. I've pushed it and updated release-blockers section in wiki.
> 

Thanks for pushing this. This looks good to me.

I reviewed what you did and it makes sense.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list