[PATCH] Fix LO_HI_LONG definition

Florian Weimer fweimer@redhat.com
Wed Jul 6 14:55:00 GMT 2016


On 07/06/2016 04:53 PM, Adhemerval Zanella wrote:
> And with you remark I noted this fix is incorrect. Since kernel commit
> 601cc11d054 the non-compat preadv/pwritev in same order, so the LO_HI_LONG
> is the same regardless off/off64_t size or wordsize.

Hah, nice.

> The tests were passing on 64-bit because files were small enough so
> the high part of offset is 0 regardless.  I will send an updated fix.
> For testcase, I am not sure it is acceptable to create a 4GB file to
> check on high part of offset (so I am accepting recommendations).

You can create a sparse file.  I don't think you have to turn it into an 
xcheck if you do that.

Florian



More information about the Libc-alpha mailing list