[PATCH 03/14 v7] Do not stack-protect ifunc resolvers.

Florian Weimer fweimer@redhat.com
Wed Jul 6 11:31:00 GMT 2016


On 07/05/2016 06:48 PM, Nick Alcock wrote:
> On 24 Jun 2016, Florian Weimer said:
>
>> On 06/07/2016 01:06 PM, Nix wrote:
>>> When dynamically linking, ifunc resolvers are called before TLS is
>>> initialized, so they cannot be safely stack-protected.
>>
>> You should base this on top of Stefan Liebler's IFUNC resolver cleanups. It should be a one-liner then.
>
> Hm. OK, I'll rebase the series atop that, once I can figure out which
> patches to use :) (or would you rather I pull those patches into my
> patch series and not rebase it? I'm happy to do either, or rebase atop
> master: I'll have to retest in any case, so the usual arguments against
> rebases don't apply, and the testing is almost entirely automated so I
> don't mind having to rerun it.)

My intention was to suggest to rebase your series on master after the 
IFUNC patches are in.

Unfortunately, this means that the stack-protector changes will not be 
part of glibc 2.24, but Adhemerval already rejected the stack-protector 
changes as such.

Florian



More information about the Libc-alpha mailing list