[PATCH 5/8] Use libc_ifunc macro for clock_* symbols in librt.

Stefan Liebler stli@linux.vnet.ibm.com
Mon Jul 4 13:49:00 GMT 2016


On 07/04/2016 11:14 AM, Florian Weimer wrote:
> On 06/23/2016 01:55 PM, Stefan Liebler wrote:
>> +# define INIT_ARCH()
>> +# define COMPAT_REDIRECT(name, proto, arglist) libc_ifunc (name,
>> &__##name)
>
> Doesn't this cause INIT_ARCH redefinition warnings in some cases?
>
> Thanks,
> Florian
>
At the moment INIT_ARCH is only defined in
-sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
-sysdeps/x86/cpu-features.h

The latter one is included in ldsodefs.h which is included in dl-vdso.h.
Thus the undef is needed in x86/i386 time.c/gettimeofday.c.

I built and run testsuite for intel, power and s390. There did not occur 
a redefinition warning.

Nevertheless, this is a good point and I add an undef INIT_ARCH before 
the definition in this patch and the other "Use libc_ifunc macro for ABC 
in libDEF." patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Use-libc_ifunc-macro-for-clock_-symbols-in-librt.patch
Type: text/x-patch
Size: 2594 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160704/e3d5dbea/attachment.bin>


More information about the Libc-alpha mailing list