[PATCH 3/6] Convert _Complex cosine functions to generated code
Paul E. Murphy
murphyp@linux.vnet.ibm.com
Fri Jul 1 04:39:00 GMT 2016
On 06/30/2016 05:36 PM, Joseph Myers wrote:
> On Thu, 30 Jun 2016, Paul E. Murphy wrote:
>
>> + if (__real__ res == M_LIT (0.0))
>
> As a general principle for all such changes:
>
> Macroization makes the code less readable, so should be avoided where not
> necessary. In particular, where implicit conversions from integers to
> floating point will suffice to give the right floating-point value with
> the right type, use integers, so use integer 0 here, and make similar
> changes throughout this patch series whenever the floating-point constant
> has a small value (not -0) representable in int. (Of course, explicit
> -0.0 does need to use a floating-point constant, not an integer constant.)
Ok, I'll bite. It's a trivial change to apply, and does not alter
code generation on the 5 platforms I'm testing with. C11/TS 18661
guarantee these constants should always be correctly promoted.
More information about the Libc-alpha
mailing list