[PATCH] powerpc: Fix dl-procinfo HWCAP

Carlos Eduardo Seo cseo@linux.vnet.ibm.com
Mon Jan 25 18:15:00 GMT 2016



On 1/25/16 4:04 PM, Adhemerval Zanella wrote:
>
> I think you should not it might be wrong for hwcap2, since the logic
> is correct for hwcap1 (I assume this hitting the new fields for
> POWER9).
>

No, this actually hits HWCAP1. If you look at hwcap.h, you will see:

#define PPC_FEATURE_PSERIES_PERFMON_COMPAT  0x00000040
#define PPC_FEATURE_TRUE_LE	    0x00000002

There's a 4 bit gap between PPC_FEATURE_PSERIES_PERFMON_COMPAT and 
PPC_FEATURE_TRUE_LE that has to be padded in _dl_powerpc_cap_flags.

The patch also assumes HWCAP1 is 64-bit long and all bits are filled, 
which is true now (if you pad those vacant 4 bits).

-- 
Carlos Eduardo Seo
Software Engineer - Linux on Power Toolchain
cseo@linux.vnet.ibm.com



More information about the Libc-alpha mailing list