[PATCH][BZ #19490] Add unwind descriptors to pthread_spin_init, etc. on i386

Torvald Riegel triegel@redhat.com
Mon Jan 25 13:06:00 GMT 2016


On Sat, 2016-01-23 at 16:18 -0800, Paul Pluzhnikov wrote:
> 2016-01-23  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
>         [BZ #19490]
>         * sysdeps/i386/i386-mcount.S (_mcount): Add unwind descriptor
>         (__fentry__): Likewise
>         * sysdeps/unix/sysv/linux/i386/_exit.S (_exit): Use ENTRY/END
>         * sysdeps/i386/nptl/pthread_spin_lock.S (pthread_spin_lock):
>         Likewise
>         * sysdeps/i386/pthread_spin_trylock.S (pthread_spin_trylock):
>         Likewise
>         * sysdeps/i386/nptl/pthread_spin_unlock.S (pthread_spin_unlock):
>         Likewise

For the spinlocks, I'd really prefer if we could just remove the asm
files.  The generic implementation should basically produce the same
code; if not, we should try to fix that instead of keeping the asm
files.



More information about the Libc-alpha mailing list