increasing default timeout significantly
Mike Frysinger
vapier@gentoo.org
Tue Jan 19 21:18:00 GMT 2016
is there a compelling reason to keep the default timeout so low ?
the vast majority of timeouts i've seen w/glibc tests are due to:
- slow system (e.g. <1 GHz cpu)
- loaded system (e.g. lots of parallelism)
even then, i've seen timeouts on system i don't generally consider
slow, or even loaded, and considering TIMEOUT is set to <=10 in ~60
tests (and <=20 in ~75 tests), it seems i'm not alone. i've just
gotten in the habit of doing `export TIMEOUTFACTOR=10` on all my
setups.
in the edge case where there is a bug in the test and the timeout is
hit, i think we all agree that's either a problem with the test or a
real bug in the library somewhere. in either case, the incident rate
should be low, so catering to that seems like the wrong trade-off.
-mike
--- a/test-skeleton.c
+++ b/test-skeleton.c
@@ -46,8 +46,9 @@
#endif
#ifndef TIMEOUT
- /* Default timeout is two seconds. */
-# define TIMEOUT 2
+ /* Default timeout is twenty seconds. Tests should normally complete faster
+ than this, but if they don't, that's abnormal (a bug) anyways. */
+# define TIMEOUT 20
#endif
#define OPT_DIRECT 1000
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160119/f176519a/attachment.sig>
More information about the Libc-alpha
mailing list