[PATCH] Add __private_ss to s390 struct tcbhead.

Marcin Kościelnicki koriakin@0x04.net
Wed Jan 13 10:05:00 GMT 2016


On 13/01/16 09:54, Andreas Schwab wrote:
> Marcin Kościelnicki <koriakin@0x04.net> writes:
>
>> diff --git a/sysdeps/s390/nptl/tls.h b/sysdeps/s390/nptl/tls.h
>> index 28a2119..0e61154 100644
>> --- a/sysdeps/s390/nptl/tls.h
>> +++ b/sysdeps/s390/nptl/tls.h
>> @@ -53,7 +53,11 @@ typedef struct
>>     int gscope_flag;
>>   #ifndef __ASSUME_PRIVATE_FUTEX
>>     int private_futex;
>> +#else
>> +  int __glibc_reserved1;
>>   #endif
>
> You can keep the name the same in all cases.  This is an internal
> header, so no namespace control.
>
>> +  /* GCC split stack support.  */
>> +  void *__private_ss;
>
> Similarily, no need for namespace control.
>
> Andreas.
>

I've named both consistently with x86.  While it doesn't matter for 
__glibc_reserved1, it'd be better to keep __private_ss called the same 
on all platforms (even if we never use it in glibc itself).

Marcin Kościelnicki



More information about the Libc-alpha mailing list