[PATCH] nptl: support thread stacks that grow up [ping]

Carlos O'Donell carlos@redhat.com
Wed Jan 13 00:07:00 GMT 2016


On 01/12/2016 05:00 PM, Mike Frysinger wrote:
> On 12 Jan 2016 13:03, Roland McGrath wrote:
>> It looks OK to me.  If you can verify that it doesn't change the generated
>> code nontrivially on x86_64, then I think that is sufficient to declare it
>> safe enough for working machines.  And grows-up machines are sufficiently
>> broken today in trunk that I'm not concerned about you making them worse.
> 
> pthread_create.c & pthread_getattr_np.c have mostly the same disassembly.
> my gcc is being weird and changing a constant in one insn depending on
> whitespace in the file.
> 
> allocatestack.c has some code shuffling, but it's the same size overall.
> 
> tests still pass on x86_64.
> 
> i'll push after the 2.23 branch.

Thanks. To be clear I have tested these patches on x86_64 and they passed
with no regressions.

Cheers,
Carlos.



More information about the Libc-alpha mailing list