[PATCH] fix #19443 - build failures with -DDEBUG

Paul Eggert eggert@cs.ucla.edu
Tue Jan 12 21:35:00 GMT 2016


On 01/12/2016 12:37 PM, Martin Sebor wrote:
> The attached patch makes it possible to build glibc with the macro
> defined.  In one instance (time/mktime.c) the macro is being used
> in a way that's incompatible with the other uses. In that case I
> renamed to avoid this problem.

Sounds good.

> -					   ? &((struct sockaddr_in6 *) nsap)->sin6_addr
> -					   : &((struct sockaddr_in *) nsap)->sin_addr),
> +					   ? (char *)&((struct sockaddr_in6 *) nsap)->sin6_addr
> +					   : (char *)&((struct sockaddr_in *) nsap)->sin_addr),

In the cast, please use (void *) instead of (char *), and put a space 
after the ")". Otherwise, looks good to me; thanks.



More information about the Libc-alpha mailing list