[PATCH v3] Add pretty printers for the NPTL lock types

Mike Frysinger vapier@gentoo.org
Fri Jan 8 08:23:00 GMT 2016


On 07 Nov 2015 20:39, Martin Galvan wrote:
> --- /dev/null
> +++ b/nptl/nptl-printers.py
> +import sys

as the linter points out, this is unused, so you should drop it

can you post a v4 with all the comments fixed ?

> +MUTEX_TYPES = {
> +    PTHREAD_MUTEX_NORMAL: ('Type', 'Normal'),
> +    PTHREAD_MUTEX_RECURSIVE: ('Type', 'Recursive'),
> +    PTHREAD_MUTEX_ERRORCHECK: ('Type', 'Error check'),
> +    PTHREAD_MUTEX_ADAPTIVE_NP: ('Type', 'Adaptive')
> +}

imo, we should have dangling commas with lists/dicts/tuples like we do
in C with arrays.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160108/500596d5/attachment.sig>


More information about the Libc-alpha mailing list